Closed
Conversation
added 2 commits
April 15, 2022 00:15
Collaborator
|
Thanks for the contributions, and sorry for the delay in our response. This change is quite invasive (as mentioned in the issue) so I want to ensure we can run our unit test suite before merging. However, unit tests currently do not work due to some issues with the test server. We hope to fix this over the coming month and I will revisit this PR. |
Collaborator
|
@eddiebergman @LennartPurucker I think we should look at this. It may be nicer to just monkey patch the parse function to a partial with the default set to |
This was referenced Oct 15, 2024
Contributor
|
Closing this as a result of recent developments: #1125 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #1125
What does this PR implement/fix? Explain your changes.
Update to pull request #1134. Deletion of test files from tasks folder reverted. Change appears to function as expected with proper formatting and passes unit tests.