Fix cache location for npm ci#550
Closed
zhenyavinogradov wants to merge 1 commit intonpm:latestfrom
zhenyavinogradov:patch-1
Closed
Fix cache location for npm ci#550zhenyavinogradov wants to merge 1 commit intonpm:latestfrom zhenyavinogradov:patch-1
npm ci#550zhenyavinogradov wants to merge 1 commit intonpm:latestfrom
zhenyavinogradov:patch-1
Conversation
When you set `<cache>` directory in npm config, `npm ci` has been using `<cache>` for storing the cache instead of `<cache>/_cacache`
ruyadorno
approved these changes
Jan 7, 2020
This was referenced Jan 10, 2020
Merged
This was referenced Jan 18, 2020
Closed
This was referenced Feb 10, 2020
This was referenced Feb 25, 2020
This was referenced Mar 9, 2020
This was referenced Mar 17, 2020
This was referenced Mar 26, 2020
This was referenced Apr 11, 2020
This was referenced Apr 17, 2020
This was referenced Oct 21, 2024
Jah-yee
pushed a commit
to Jah-yee/cli
that referenced
this pull request
Apr 16, 2026
…#550) * feat: handle SIGTERM in +watch and +subscribe for clean shutdown Add shared shutdown_signal() helper that merges SIGINT and SIGTERM into a single future. Replace tokio::signal::ctrl_c() in both watch and subscribe pull loops so they exit cleanly under Kubernetes, Docker, and systemd. On non-Unix platforms, only SIGINT (Ctrl+C) is handled. * fix: register SIGTERM handler once via persistent background task Use OnceLock + tokio::sync::Notify so the signal handler stays active for the process lifetime. Eliminates the race window between loop iterations where a SIGTERM would bypass the handler. * fix: graceful fallback when SIGTERM registration fails Replace expect() with match: if signal(SIGTERM) fails, log a warning and fall back to SIGINT-only. Prevents silent task death that would hang all shutdown_signal() callers indefinitely. * fix: prevent spurious shutdown from ignored ctrl_c errors Use Ok(_) pattern matching in select! branches and expect() for standalone ctrl_c().await calls. Previously .ok() silently swallowed errors, causing notify_waiters() to fire immediately. * fix: handle ctrl_c error in select! to avoid losing SIGINT branch Bind the full Result from ctrl_c() and expect() on it instead of pattern matching Ok(_), which silently dropped the branch on Err. --------- Co-authored-by: jpoehnelt-bot <jpoehnelt-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you set
<cache>directory in npm config,npm cihas been using<cache>for storing the cache instead of<cache>/_cacache