fix(arborist): handle link nodes in old lockfiles correctly#4614
Merged
lukekarrys merged 1 commit intolatestfrom Mar 28, 2022
Merged
fix(arborist): handle link nodes in old lockfiles correctly#4614lukekarrys merged 1 commit intolatestfrom
lukekarrys merged 1 commit intolatestfrom
Conversation
wraithgar
approved these changes
Mar 24, 2022
Contributor
|
no statistically significant performance changes detected timing results
|
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we were previously assuming that a node with no version property is a link, however in old lockfiles a link target is also in the inventory and has a version so this check does not catch all edge cases
closes #3628