test_runner: exclude test files from coverage by default#56060
Merged
nodejs-github-bot merged 5 commits intonodejs:mainfrom Dec 17, 2024
Merged
test_runner: exclude test files from coverage by default#56060nodejs-github-bot merged 5 commits intonodejs:mainfrom
nodejs-github-bot merged 5 commits intonodejs:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address #53508.
I'm opening this PR since #55633 seems to be stale.
This PR contains the feature and some changes to reduce its footprint.
Note: The reason behind
lazyMinimatchis to avoid experimental warnings related tomatchesGlob.I'm not entirely convinced about the change I introduced to the
--test-coverage-excludeand--test-coverage-includeflags.Regarding:
@cjihrig
#55633 (review)
I think we should just exclude the files specified by the user, as it's the most common scenario.
If a user imports other tests from different files, I would expect them to exclude those manually.
WDYT?