Skip to content

src,permission: add multiple allow-fs-* flags#49047

Merged
nodejs-github-bot merged 7 commits intonodejs:mainfrom
Ceres6:permission-multiple-allows
Aug 17, 2023
Merged

src,permission: add multiple allow-fs-* flags#49047
nodejs-github-bot merged 7 commits intonodejs:mainfrom
Ceres6:permission-multiple-allows

Conversation

@Ceres6
Copy link
Copy Markdown
Contributor

@Ceres6 Ceres6 commented Aug 6, 2023

Breaking change: Support for a single comma separates list for allow-fs-* flags is removed.

This means that

--alow-fs-read=/path/to/file.txt,/other/file/path.txt

Will be interpreted as a single file.

When using a single flag and including commas in said flag a warning will be emitted explaining the change.

Instead now multiple flags can be passed to allow multiple paths.

--allow-fs-read=/path/to/file.txt --allow-fs-read=/other/file/path.txt

Will allow access to both paths.

Fixes: nodejs/security-wg#1039

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. permission Issues and PRs related to the Permission Model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to includes "," or "*" char self in --allow-fs-read?

6 participants