esm: convert resolve hook to synchronous#43363
Merged
nodejs-github-bot merged 15 commits intonodejs:mainfrom Jun 18, 2022
Merged
esm: convert resolve hook to synchronous#43363nodejs-github-bot merged 15 commits intonodejs:mainfrom
resolve hook to synchronous#43363nodejs-github-bot merged 15 commits intonodejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes
This PR converts the
resolvehook from asynchronous to synchronous to align with the general ecosystem (most namely browsers). When aresolvehook returns a thenable (eg async or promise), an error is specifically thrown.It also converts
import.meta.resolve()to synchronous.Unblocks
next<HookName>multiple times #43303