deps: Intl: ICU 58 bump

[srl295]

• Subsystem: deps
• followon to ICU 57 bump in deps: Intl: ICU 57 bump #6058
• ICU 58 won't be out until October. http://site.icu-project.org

ICU 58 shipped 2016-Oct-21 - http://site.icu-project.org/download/58

[srl295]

fyi @ofrobots

[srl295]

I had no functional problems getting ICU58m1 to run in srl295@770a5ff (big commit)

License file needs work, but I already have todos on that…

If anyone is curious how git manages such an upgrade:

[icu4c-58m1 770a5ff] *NOT FOR MERGING OR PRODUCTION* — experimental build of icu4c 58m1
 Date: Fri Jul 22 12:34:27 2016 -0700
 894 files changed, 17720 insertions(+), 14946 deletions(-)
 rewrite deps/icu-small/source/common/ubidi_props_data.h (66%)
 rewrite deps/icu-small/source/common/ucase_props_data.h (72%)
 rewrite deps/icu-small/source/common/uchar_props_data.h (86%)
 rename deps/icu-small/source/data/in/{icudt57l.dat => icudt58l.dat} (65%)

(edit- this is a fixed commit… I had committed with the wrong line endings before, which bloated the diffs unsurprisingly)

this script says that the commit is 10,832,068 bytes.

Also, on macOS the binary size of node increased by 48,568 bytes with this commit.

We did do a copyright change (but the license is the same MIT/X) in this rev, so it's probably larger than normal.

[srl295]

So at this point there's nothing known that needs updating to allow use of ICU 58 when it comes out. I'll leave this open for the actual commit later this year.

[srl295]

ICU 58 is planning to:

• upgrade project files to VS 2015 (no effect on Node)
• require C++11 for c++ code compiled against ICU

[jasnell]

@srl295 ... when in october is 58 expected to be released?

[jasnell]

require C++11 for c++ code compiled against ICU

This one may be a challenge. Will C++11 be required to build ICU in our tree?

[addaleax]

@jasnell Node’s own code does use C++11 features, fwiw.

[ofrobots]

This one may be a challenge. Will C++11 be required to build ICU in our tree?

Depends on the timing. V8 LKGR also requires C++11 now.

[srl295]

@jasnell right, I understood from @mhdawson that c++11 features required elsewhere were already hitting issues.
from http://icu-project.org :

2016-09-15: 58 Release Candidate
2016-10-01: 58 Release (58.1)

[jasnell]

Yeah, I've seen it a few times. I guess with v7 we'll just have to make the c++11 requirement official.

[jasnell]

@addaleax ... oh! oy! ... I'd completely missed that ;-) carry on then lol