EventEmitter gets TypeError if EventEmitter.prototype.addListener is called directly.

[yosuke-furukawa]

I got following TypeError. the detail is here (sequelize/sequelize#2966).

TypeError: undefined is not a function
     at Promise.addListener (events.js:154:18)
     at Promise.on (/Users/yosuke/go/src/github.com/yosuke-furukawa/Hexi/node_modules/sequelize/lib/promise.js:118:31)

I think Sequelize module is wrong, EventEmitter.prototype.addListener should not be called directly. However, I don't think this error message is easy to understand. And io.js seems to break node.js compatible on events.

I have 4 options, I would like to discuss about the behavior.

1. If this.getMaxListeners is undefined, events module prints helpful message like "EventEmitter.prototype.addListener should not called directly."
2. If this.getMaxListeners is undefined, return the default EventEmitter.defaultMaxListeners.
3. 1. + 2.
4. Keep this behavior.

[Fishrock123]

Seems like it's mostly Sequalize abusing EventEmitter.

[bnoordhuis]

Agreed, but we can't welch on our promise of joyent/node compatibility with little things like this. First one to review #527 gets a cookie.

[yosuke-furukawa]

LGTM.

[bnoordhuis]

Cheers, fixed in ee9cd00. Thanks for the bug report, Yosuke.