build: missing defenitions from headers tarball

[refack]

• Version:
• Platform:
• Subsystem:

I did a semi-thorough grep for symbols our deps use to customise their build, and found a few. First one might have helped find #23122 earlier.
Question is, should we define them, and how (probably via common.gypi)?

• v8config.h

#if defined(V8_DEPRECATION_WARNINGS) && V8_HAS_ATTRIBUTE_DEPRECATED_MESSAGE
#if defined(V8_IMMINENT_DEPRECATION_WARNINGS) && \

• zlib\zconf.h

#if defined(ZLIB_CONST) && !defined(z_const)
\include\node\openssl\zlib.h
#ifdef HAVE_UNISTD_H    /* may be set to #if 1 by ./configure */
#  define Z_HAVE_UNISTD_H
#endif
#ifdef HAVE_STDARG_H    /* may be set to #if 1 by ./configure */
#  define Z_HAVE_STDARG_H
#endif

• openssl

# if defined(OPENSSL_NO_STDIO)
#if defined(OPENSSL_NO_ASM)
# if defined(OPENSSL_THREADS) && !defined(CRYPTO_TDEBUG)
# elif defined(OPENSSL_SYS_WINDOWS) && defined(OPENSSL_OPT_WINDLL)

@nodejs/build-files

[addaleax]

The zlib symbols should all be taken care of – we have const available, HAVE_STDARG_H is not used for the features we need in core, and Z_HAVE_UNISTD_H is already set in deps/zlib/zlib.gyp.

OPENSSL_NO_ASM is provided by our own configure script’s --openssl-no-asm.
OPENSSL_THREADS sounds like something we don’t need because we already provide threadpool-based crypto functions.

[refack]

The problem I see is that our configuration and gyp files are not necessarily propogated to the headers tarball.

[addaleax]

The problem I see is that our configuration and gyp files are not necessarily propogated to the headers tarball.

I’m not sure but I don’t think it’s an issue – the only thing that could potentially be defined is OPENSSL_NO_ASM, but that shouldn’t affect ABI/API, so it’s okay to have diverging definitions (and probably doesn’t have any impact at all on addons)?