Internal modules problem with $ in identifiers on AIX

[mhdawson]

Support for internal modules was added in:

2db758c

As part of this, this line in tools/utils.py converts a path name into an identifier

   escaped_id = id.replace('/', '$')

Unfortunately support for a $ in an identifier is implementation specific and is not supported on AIX which causes compiler failures on the generated node_natives.h file.

I'd propose to change the line to:

  escaped_id = id.replace('/', '_')

@vkurchatkin comments ?

[vkurchatkin]

I think it's fine. I chose $ instead of _ in the first place to avoid possible collisions, it's rather unlikely that we will have $ in paths, but in generally it's not a big deal, I think.

[mhdawson]

Thanks, I'll include that change when I submit the PR to add AIX support

[brendanashworth]

I think this can be closed for now, with discussion continuing on #2364. It can always be reopened, of course.