test-ttywrap.readstream does not check if a valid TTY fd is available

[psmarshall]

• Version: master
• Platform: all
• Subsystem: tests

We have a test failure that occurs on our node build bot that we can't reproduce locally, that happens in test-ttywrap.readstream.js. We get the following results:

not ok 45 async-hooks/test-ttywrap.readstream
  duration_ms: 0.89
  severity: fail
  stack: |-
    tty.js:47
        handle: new TTY(fd, true)
                ^
    
    Error: EINVAL: invalid argument, uv_tty_init
        at new ReadStream (tty.js:47:13)
        at Object.<anonymous> (*..snip..*/node.js/test/async-hooks/test-ttywrap.readstream.js:13:19)
        at Module._compile (module.js:569:30)
        at Object.Module._extensions..js (module.js:580:10)
        at Module.load (module.js:503:32)
        at tryModuleLoad (module.js:466:12)
        at Function.Module._load (module.js:458:3)
        at Function.Module.runMain (module.js:605:10)
        at startup (bootstrap_node.js:158:16)
        at bootstrap_node.js:575:3
  ...
ok 46 async-hooks/test-ttywrap.writestream # skip no valid TTY fd available

test-ttywrap.writestream.js seems to check whether the TTY fd is available and then skip if not - does it make sense to do the same thing in the readstream test?

[addaleax]

test-ttywrap.writestream.js seems to check whether the TTY fd is available and then skip if not - does it make sense to do the same thing in the readstream test?

I would think so, yes.

[trevnorris]

Have fix at: #13991