node-addon-api fails to build against node 4.x

[gabrielschulhof]

$ nvm use 4
$ npm test

Observe build failure.

[gabrielschulhof]

I tweaked the node-test-node-addon-api job a bit:

https://ci.nodejs.org/job/node-test-node-addon-api/1/ (nightly - good)
vs.
https://ci.nodejs.org/job/node-test-node-addon-api/2/ (v4 - bad)

[gabrielschulhof]

v6 is also bad: https://ci.nodejs.org/job/node-test-node-addon-api/3/

[mhdawson]

@gabrielschulhof can I assume you are investigating ? It is possible that its related to the async changes that were landed in master/head but I doubt have been backported to 4/6

[gabrielschulhof]

Is this #144?

[gabrielschulhof]

@mhdawson almost certainly, since it's precisely async that is tripping things up.

[gabrielschulhof]

Actually, node-addon-api fails to build against nov 8.4.0 too. So AFAICT it's basically broken against any version of node other than the latest.

[gabrielschulhof]

I'm starting to go through the errors, and I've noticed that we've introduced a call to v8::FunctionCallbackInfo's NewTarget() method. This method is not available in previous versions of V8, so can we fall back onto This()? Can NewTarget() be something other than This() when IsConstructCall() is true? @nodejs/addon-api

[bnoordhuis]

Can NewTarget() be something other than This() when IsConstructCall() is true?

Yes, see nodejs/node#15681. You could back-port nodejs/node#11652 to v4.x.