Skip to content

Adds check for empty thousands separator#1089

Open
kjeldahl wants to merge 1 commit intonicolaskruchten:masterfrom
kjeldahl:No-thousandsSep-#914
Open

Adds check for empty thousands separator#1089
kjeldahl wants to merge 1 commit intonicolaskruchten:masterfrom
kjeldahl:No-thousandsSep-#914

Conversation

@kjeldahl
Copy link
Copy Markdown

A check is added for empty thousands separator so it is possible to render numbers without a thousands separator
#914

A check is added for empty thousands seperator so it is possible to render numbers without a thoudsands seperator
@kjeldahl
Copy link
Copy Markdown
Author

@nicolaskruchten I was unable to compile and test the patch due to some node setup issues.

@co-operate
Copy link
Copy Markdown

+1
Had the same issue, came to the same solution. In pivot.js this will result in:

if (thousandsSep) {
  while (rgx.test(x1)) {
    x1 = x1.replace(rgx, '$1' + thousandsSep + '$2');
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants