Adds check for empty thousands separator#1089
Open
kjeldahl wants to merge 1 commit intonicolaskruchten:masterfrom
Open
Adds check for empty thousands separator#1089kjeldahl wants to merge 1 commit intonicolaskruchten:masterfrom
kjeldahl wants to merge 1 commit intonicolaskruchten:masterfrom
Conversation
A check is added for empty thousands seperator so it is possible to render numbers without a thoudsands seperator
Author
|
@nicolaskruchten I was unable to compile and test the patch due to some node setup issues. |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A check is added for empty thousands separator so it is possible to render numbers without a thousands separator
#914