fix: change stop hook from blocking to warning to prevent auto-commits#1451
Open
StellaHuang95 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: change stop hook from blocking to warning to prevent auto-commits#1451StellaHuang95 wants to merge 1 commit intomicrosoft:mainfrom
StellaHuang95 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the stop hook from
"decision": "block"to"decision": "warn"so the agent asks the user before committing instead of auto-committing.Background
The
stop_hook.pyis a pre-session stop hook that runs when an agent (maintainer) session ends. It checks the git state for:.ts/.tsxfiles) — reminds the agent to run pre-commit checks (lint, type-check, tests)Problem
Previously, both checks used
"decision": "block", which prevented the agent from ending the session until the condition was resolved. The reason text explicitly told the agent to commit changes (e.g., "If checks pass and changes are ready, commit them"). This combination caused the agent to auto-commit every time without asking the user, which is undesirable when the user wants to review changes before committing.Changes
"decision": "block"→"decision": "warn"for both the TS changes check and the staged changes check. The agent sees the warning but is no longer forced to act on it.Files Changed
.github/hooks/scripts/stop_hook.py