fix(48948): constructor can't be the name of class accessors and generators#48954
Merged
DanielRosenwasser merged 3 commits intomicrosoft:mainfrom May 13, 2022
Merged
fix(48948): constructor can't be the name of class accessors and generators#48954DanielRosenwasser merged 3 commits intomicrosoft:mainfrom
DanielRosenwasser merged 3 commits intomicrosoft:mainfrom
Conversation
DanielRosenwasser
approved these changes
May 11, 2022
Member
DanielRosenwasser
left a comment
DanielRosenwasser
left a comment
There was a problem hiding this comment.
This change looks good. We should probably issue these errors in plain JS files. @sandersn will the current logic do that? Will we need a test?
Member
|
sandersn
approved these changes
May 12, 2022
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Looks good!
Please add the new errors to plainJSErrors in program.ts and a short test to plainJSGrammarErrors.ts in tests/conformance/salsa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48948