Fix getTypeFromJSDocValueReference#35360
Merged
elibarzilay merged 1 commit intomicrosoft:masterfrom Nov 27, 2019
Merged
Conversation
Member
|
@typescript-bot cherry-pick this to release-3.7 |
Collaborator
|
Hey @RyanCavanaugh, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually. |
sandersn
approved these changes
Nov 26, 2019
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
I think is a good patch fix but we'll need to understand the problem better for a permanent fix.
When using `{import('./b').FOO}` which is defined as a string literal,
`valueType` doesn't have a `symbol`. Leave it for the fallback value
for now.
This was exposed in 8223c07.
Fixes microsoft#34869.
Contributor
Author
|
@typescript-bot cherry-pick this to release-3.7 |
Collaborator
|
Hey @elibarzilay, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.7 manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
{import('./b').FOO}which is defined as a string literal,valueTypedoesn't have asymbol.This was exposed in 8223c07.
Fixes #34869.