Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens up a couple of flaky browser-driven UI test harness behaviors and records an agent workflow preference, improving reliability of Playwright-based verification in the PrompterOne UI test suite.
Changes:
- Update the recording file harness to advance on a timeout when
requestVideoFrameCallbackis unavailable or never fires. - Fix the Learn startup trace sampling loop to cap the RAF passes without an extra iteration.
- Document a preference to work on the active workspace branch rather than using temporary worktrees by default.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/PrompterOne.App.UITests/Media/recording-file-harness.js |
Makes frame-wait logic progress even when requestVideoFrameCallback doesn’t fire, reducing test hangs/flakiness. |
tests/PrompterOne.App.UITests/Learn/LearnStartupAlignmentTests.cs |
Adjusts RAF pass counting to avoid an extra capture pass and better honor the max-pass cap. |
AGENTS.md |
Adds guidance about avoiding throwaway worktrees/copies when the current workspace branch is available. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification