Fix LA dismissal handling and improve restart reliability#588
Merged
bjorkert merged 6 commits intoloopandlearn:live-activityfrom Apr 9, 2026
Merged
Fix LA dismissal handling and improve restart reliability#588bjorkert merged 6 commits intoloopandlearn:live-activityfrom
bjorkert merged 6 commits intoloopandlearn:live-activityfrom
Conversation
Dismissing the LA was silently killing Watch data: refreshFromCurrentState guarded on !dismissedByUser before calling performRefresh, so the Watch received nothing after a dismiss. Fix: - Remove the LA guard from refreshFromCurrentState — Watch and store must update regardless of LA state. - In performRefresh, capture the dedup result (snapshotUnchanged) before saving to the store, then run store save + Watch send unconditionally. The laEnabled/dismissedByUser/dedup guards now gate only the LA update. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comment out the line that sends the snapshot to WatchConnectivityManager.
Refactor foreground restart logic to end existing activities before starting a new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves Live Activity reliability and restart behavior. Fixes a race condition where iOS dismissals could be misclassified as user actions, preventing recovery. Introduces a lightweight “breadcrumb” signal from the widget extension to better detect stale or non-updating activities. Refines foreground logic to restart safely and avoid duplicate or conflicting lifecycle events, while preserving user intent.