Redesign carbs remote screen with picker-based absorption time#567
Merged
marionbarker merged 4 commits intodevfrom Apr 8, 2026
Merged
Redesign carbs remote screen with picker-based absorption time#567marionbarker merged 4 commits intodevfrom
marionbarker merged 4 commits intodevfrom
Conversation
…e hour and minute states, enhancing clarity and usability
Collaborator
TestSo close. The SE 2nd gen screen running iOS 18 does not show the "Done" button. The only way I know it's a "Done" button is from the code and looking at the same screen on an iPhone 15. And no, you can't scroll the screen to see the button.
Requested changeAs long as this needs work - set up variables as noted in the review. Don't hard code them as numbers. |
marionbarker
requested changes
Mar 30, 2026
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Fix the screen issue for small screens. Request modifications as noted. I did not highlight every line - I think you can extrapolate.
…improved layout and navigation experience
…rable maxPastHours and maxFutureHours constants
…le limits and presets
marionbarker
approved these changes
Apr 8, 2026
Collaborator
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Approved by code review and test. Thanks for the fix and the updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #558 to keep that PR focused on units/metrics.