Modify CF template before nested stacks get created#26
Open
rmbl wants to merge 1 commit intoleftclickben:masterfrom
Open
Modify CF template before nested stacks get created#26rmbl wants to merge 1 commit intoleftclickben:masterfrom
rmbl wants to merge 1 commit intoleftclickben:masterfrom
Conversation
|
Is there anything blocking this from being merged and released? |
Author
|
I should probably fix the tests. Other than that it has been working since then over a few hundred deployments for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're using serverless-plugin-split-stacks to split the resulting CF template into nested stacks. This occurs on
after:aws:package:finalize:mergeCustomProviderResourceswhich is part ofpackage:finalize. Because of this the Stage gets added too late and leads to errors when deploying it to AWS.This PR moves the modifications from this plugin to the beginning of
package:finalizeto fix that.