Conversation
5f65202 to
8e04ace
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7350de8. Configure here.
hyperbrowser/client/managers/sync_manager/sandboxes/sandbox_processes.py
Outdated
Show resolved
Hide resolved
NikhilShahi
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Medium risk because it changes how process commands are serialized (quoting/flattening
argsand droppinguse_shell) and addsrunAspropagation across runtime file/process APIs, which could affect command execution and permissions behavior.Overview
Adds first-class user impersonation support to sandbox runtime calls by introducing
run_as/runAsonSandboxExecParams, threading it throughSandboxHandle.exec, and providingSandboxFilesApi.with_run_as()to applyrunAsto all file requests.Refactors process execution to accept either a command string or
SandboxExecParamsplus optional overrides (cwd,env, timeouts,run_as), normalizing legacy fields by shell-quoting and foldingargsintocommandwhile omittingargs/useShellfrom the wire payload.Updates E2E/contract tests to use the new
with_run_as("root")pattern, to acceptcreateevents in file watching assertions, and to add retry/backoff when creating sandboxes from newly-created snapshots; bumps SDK version to0.90.1.Reviewed by Cursor Bugbot for commit fd38cb4. Bugbot is set up for automated code reviews on this repo. Configure here.