Conversation
NikhilShahi
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes the sandbox create wire contract and model validation, which could break clients/servers if the backend or payloads don’t match the new
vcpus/memMiB/diskSizeMiBfields. Adds new e2e coverage but the change touches core sandbox lifecycle APIs.Overview
Adds optional
cpu,memory_mib, anddisk_mibsizing toCreateSandboxParams, serializing tovcpus/memMiB/diskSizeMiB, and surfaces these fields onSandbox/SandboxDetailplus sync/asyncSandboxHandleproperties.Enforces that resource sizing is only allowed for image-based launches (rejects snapshot-based launches with these fields), updates README examples, bumps version to
0.89.2, and adds/updates tests including a new e2e that verifies the requested resources are reflected both in API responses and inside the running sandbox.Written by Cursor Bugbot for commit d13818b. This will update automatically on new commits. Configure here.