Conversation
Agent-Logs-Url: https://github.com/hackclub/construct/sessions/eea3c7cd-8b5b-4eb4-a163-c6ed21d31ac7 Co-authored-by: ArcaEge <40526225+ArcaEge@users.noreply.github.com>
|
@copilot the apply button is always greyed out |
|
@ArcaEge The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
3 similar comments
|
@ArcaEge The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@ArcaEge The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@ArcaEge The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@copilot the apply button is always greyed out |
|
@ArcaEge The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
1 similar comment
|
@ArcaEge The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
Agent-Logs-Url: https://github.com/hackclub/construct/sessions/4d34f1d3-68f1-4201-bf7b-168f46df78ac Co-authored-by: ArcaEge <40526225+ArcaEge@users.noreply.github.com>
Agent-Logs-Url: https://github.com/hackclub/construct/sessions/4d34f1d3-68f1-4201-bf7b-168f46df78ac Co-authored-by: ArcaEge <40526225+ArcaEge@users.noreply.github.com>
Fixed in commit |
|
@ArcaEge The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
1 similar comment
|
@ArcaEge The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@copilot add it to ysws-review too. also, remove the need for the filtered=1 parameter |
|
@ArcaEge The model You can try again without specifying a model (just If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: |
|
@ArcaEge Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
2 similar comments
|
@ArcaEge Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
|
@ArcaEge Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
…am from all pages Agent-Logs-Url: https://github.com/hackclub/construct/sessions/484fbb40-e36b-45f7-8b2a-6fd0c8390c18 Co-authored-by: ArcaEge <40526225+ArcaEge@users.noreply.github.com>
Done in commit
|
Filters on the review, printer, admin, and ysws-review pages are now stored as URL parameters. When a user applies filters and navigates away (e.g. to a project detail page), clicking back in the browser restores the exact filter they had applied.
Changes
For each of the 6 affected pages — Review, Print, Admin Orders, Admin Printer Fulfilment, Admin Printer Purchases, and YSWS Review:
+page.server.tsload()to accepturland read filter values fromurl.searchParams['submitted']for review,['t1_approved']for print,['queued']for printer fulfilment,['printed']for ysws-review)data.fieldsso the form can pre-populateactionsexport from ysws-review (no longer needed since filtering uses GET)url.searchParams.size > 0— no sentinel parameter needed+page.sveltemethod="POST"tomethod="GET"use:enhancefrom$app/formswithnavigatingfrom$app/statefor the pending/disabled button state (navigating.to !== null)form?.fields.*references todata.fields.*How it works
url.searchParams.size === 0→ defaults applied?status=building&status=t1_approvedload()re-runs with URL params → filter is restored ✓Security Summary
No security vulnerabilities were introduced. CodeQL found 0 alerts.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.