Add Grand.Mapping project reference to multiple modules#669
Merged
KrzysztofPajak merged 5 commits intodevelopfrom Mar 30, 2026
Merged
Add Grand.Mapping project reference to multiple modules#669KrzysztofPajak merged 5 commits intodevelopfrom
KrzysztofPajak merged 5 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Grand.Mapping project reference to multiple module projects so they can compile against mapping-related types without relying on transitive dependencies.
Changes:
- Added
ProjectReferencetosrc/Core/Grand.Mapping/Grand.Mapping.csprojin several module.csprojfiles. - Matched existing dependency metadata in modules that already use
<ExcludeAssets>runtime</ExcludeAssets>.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Modules/Grand.Module.ScheduledTasks/Grand.Module.ScheduledTasks.csproj | Adds Grand.Mapping project reference alongside other Core references. |
| src/Modules/Grand.Module.Migration/Grand.Module.Migration.csproj | Adds Grand.Mapping project reference to the module dependencies. |
| src/Modules/Grand.Module.Installer/Grand.Module.Installer.csproj | Adds Grand.Mapping project reference to the module dependencies. |
| src/Modules/Grand.Module.Api/Grand.Module.Api.csproj | Adds Grand.Mapping project reference alongside other Core references. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/Modules/Grand.Module.ScheduledTasks/Grand.Module.ScheduledTasks.csproj
Outdated
Show resolved
Hide resolved
src/Modules/Grand.Module.Migration/Grand.Module.Migration.csproj
Outdated
Show resolved
Hide resolved
src/Modules/Grand.Module.Installer/Grand.Module.Installer.csproj
Outdated
Show resolved
Hide resolved
…Tasks.csproj Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
1 similar comment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.