feat(core): Add generalist agent.

[joshualitt]

Fixes 15972

[gemini-code-assist]

Summary of Changes

Hello @joshualitt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the agent system by introducing a new, highly capable 'Expert Agent'. This agent is designed to tackle a broad range of tasks by leveraging all available tools in a non-interactive fashion. The changes include comprehensive configuration updates, seamless integration into the agent registration process, and modifications to the system prompt generation to support the agent's specific operational mode. This addition provides a powerful, versatile tool within the core framework.

Highlights

• New Expert Agent (Generalist): Introduced a new ExpertAgent designed as a general-purpose AI agent with access to all available tools. This agent operates in a non-interactive mode.
• Configuration and Registry Integration: Added ExpertAgentSettings to the core configuration, allowing the agent's enablement to be controlled. The AgentRegistry now conditionally registers the ExpertAgent based on these settings.
• System Prompt Flexibility: The getCoreSystemPrompt function was updated to accept an optional interactiveOverride parameter, enabling agents like the ExpertAgent to explicitly define their interactive behavior (e.g., non-interactive).
• Enhanced Testing Utilities: A new makeMockedConfig helper function was added to registry.test.ts to streamline the creation of mocked configurations, improving test readability and maintainability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: +3.16 kB (+0.01%)

Total Size: 23.1 MB

Filename	Size	Change
./bundle/gemini.js	23.1 MB	+3.16 kB (+0.01%)

ℹ️ View Unchanged

Filename	Size
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB
./bundle/sandbox-macos-permissive-open.sb	890 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB

_{compressed-size-action}

[gemini-code-assist]

Code Review

The pull request introduces a new general-purpose AI agent. However, there's a significant naming inconsistency: the pull request title and the intended purpose suggest a "generalist" agent, but the implementation consistently uses the name "ExpertAgent" across all new and modified files. This discrepancy should be resolved to maintain clarity and consistency within the codebase. It is recommended to rename ExpertAgent to GeneralistAgent and update all related references accordingly.

[abhipatel12]

Looks good! had a few comments

[gundermanc]

Approving from code perspective but I think we should file something to define the behaviors and iterate on prompts.

[abhipatel12]

LGTM!