Skip to content

feat: do not collect VCS information when loading code#6349

Merged
ldez merged 2 commits intogolangci:mainfrom
pgimalac:pgimalac/force-disable-vcs-info
Feb 9, 2026
Merged

feat: do not collect VCS information when loading code#6349
ldez merged 2 commits intogolangci:mainfrom
pgimalac:pgimalac/force-disable-vcs-info

Conversation

@pgimalac
Copy link
Copy Markdown
Contributor

@pgimalac pgimalac commented Feb 6, 2026

Fixes #6348.

Explicitly disables collecting VCS information when loading packages, since it is not needed and can take a significant time.

@boring-cyborg
Copy link
Copy Markdown

boring-cyborg bot commented Feb 6, 2026

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 6, 2026

CLA assistant check
All committers have signed the CLA.

@ldez ldez self-requested a review February 6, 2026 11:47
@pgimalac
Copy link
Copy Markdown
Contributor Author

pgimalac commented Feb 9, 2026

@ldez sorry for the delay I had to wait for my company to approve the CLA, it's done !

@ldez ldez added area: CLI Related to CLI and removed waiting for: CLA sign labels Feb 9, 2026
@ldez
Copy link
Copy Markdown
Member

ldez commented Feb 9, 2026

To avoid any kind of regression, I added an option to remove this flag if needed.

@ldez ldez changed the title Do not collect VCS information when loading code feat: do not collect VCS information when loading code Feb 9, 2026
@ldez ldez force-pushed the pgimalac/force-disable-vcs-info branch from d8ca5ee to 0e5c8e1 Compare February 9, 2026 18:40
@ldez ldez added enhancement New feature or improvement topic: speed and removed area: CLI Related to CLI labels Feb 9, 2026
@ldez ldez added this to the unreleased milestone Feb 9, 2026
@pgimalac
Copy link
Copy Markdown
Contributor Author

pgimalac commented Feb 9, 2026

Fair enough 👍

@ldez
Copy link
Copy Markdown
Member

ldez commented Feb 9, 2026

I take the opportunity to ask if you can suggest your company to sponsor this project.
I already tried to contact it, but I didn't received any answer.

My only source of income is from donations.
This will be appreciated, thank you ❤️

https://donate.golangci.org
https://donate.ldez.dev

@pgimalac
Copy link
Copy Markdown
Contributor Author

pgimalac commented Feb 9, 2026

I'll forward ! (but can't guarantee anything)

@ldez ldez merged commit 4636637 into golangci:main Feb 9, 2026
18 checks passed
@ldez ldez modified the milestones: unreleased, v2.9 Feb 10, 2026
gh-worker-dd-mergequeue-cf854d bot pushed a commit to DataDog/datadog-agent that referenced this pull request Feb 16, 2026
### What does this PR do?
Bump golangci-lint to benefit from golangci/golangci-lint#6349.

### Motivation
The fix significantly reduces linting duration in CI:
- Linux: 11min -> 5min
- Windows: 25min -> 17min

(once it's merged we'll have more pipelines and we'll have a more stable estimate of the impact, those numbers are from a few pipelines on this branch)

Locally, it removes around 2min from the lint (from 4-5min to 2-3).

### Describe how you validated your changes
CI

### Additional Notes


Co-authored-by: pierre.gimalac <pierre.gimalac@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or improvement topic: speed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Golangci-lint collects VCS information while it's not needed

3 participants