Migrate MCP Apps support from insiders mode to feature flag with insiders opt-in#2282
Open
mattdholloway wants to merge 2 commits intomainfrom
Open
Migrate MCP Apps support from insiders mode to feature flag with insiders opt-in#2282mattdholloway wants to merge 2 commits intomainfrom
mattdholloway wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates MCP Apps (interactive UI forms) enablement from “insiders mode” to an explicit feature flag (remote_mcp_ui_apps), while keeping backward compatibility by treating insiders mode as implying the flag.
Changes:
- Introduces
github.MCPAppsFeatureFlag(remote_mcp_ui_apps) and wires it through stdio/HTTP feature checking with an insiders-mode transitional fallback. - Adds inventory builder support (
WithMCPApps) to strip/keep MCP Apps UI metadata (Meta["ui"]) based on the feature flag. - Updates tool behavior gates and documentation to reference the feature flag instead of insiders mode.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/inventory/registry_test.go | Renames/extends tests for MCP Apps gating and meta stripping; adds stripMetaKeys coverage. |
| pkg/inventory/builder.go | Adds WithMCPApps, separates insiders stripping from MCP Apps UI metadata stripping, and introduces stripMetaKeys. |
| pkg/http/server.go | Whitelists remote_mcp_ui_apps for X-MCP-Features and adds transitional insiders behavior in feature checker. |
| pkg/http/handler.go | Applies WithInsidersMode and WithMCPApps to the inventory builder based on request context/header features. |
| pkg/github/pullrequests.go | Gates PR UI form behavior on remote_mcp_ui_apps feature flag instead of insiders mode. |
| pkg/github/pullrequests_test.go | Updates UI-gate test setup to use feature checker-based deps rather than InsidersMode. |
| pkg/github/issues.go | Gates issue UI form behavior on remote_mcp_ui_apps feature flag instead of insiders mode. |
| pkg/github/issues_test.go | Updates UI-gate test setup to use feature checker-based deps rather than InsidersMode. |
| pkg/github/feature_flags.go | Adds the exported MCPAppsFeatureFlag constant. |
| internal/ghmcp/server.go | Ensures stdio “insiders mode” also enables remote_mcp_ui_apps; registers UI resources based on the flag. |
| docs/server-configuration.md | Documents feature flags and MCP Apps configuration via X-MCP-Features / --features. |
| docs/insiders-features.md | Removes MCP Apps from insiders-only list; points to feature-flag configuration. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request transitions MCP Apps from an insiders-only experimental feature to a general feature flag (
remote_mcp_ui_apps) that can be enabled independently.Why
Closes https://github.com/github/copilot-mcp-core/issues/1471
What changed
MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs