This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Explicitly open repository when clone completes#2004
Merged
Conversation
Explicitly open repository on Visual Studio 2015 and 2017. Although this sometimes happens automatically on Visual Studio 2017, it doesn't happen consistently.
Codecov Report
@@ Coverage Diff @@
## master #2004 +/- ##
=========================================
Coverage ? 40.25%
=========================================
Files ? 405
Lines ? 17344
Branches ? 2391
=========================================
Hits ? 6982
Misses ? 9834
Partials ? 528
|
Contributor
|
@jcansdale thanks so much for fixing this problem. I had noticed it in the past but wasn't really sure why it was happening. This looks great to me! ✨ |
grokys
approved these changes
Oct 25, 2018
Contributor
grokys
left a comment
grokys
left a comment
There was a problem hiding this comment.
Works nicely and really simple, that's the sort of review I like 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a clone completes in Visual Studio 2017, the repository context would only consistently change if there was no solution or folder open. This PR explicitly opens the repository when the clone completes. This makes the behavior consistent with Visual Studio 2015.
ITeamExplorerServices.OpenRepositoryfor both Visual Studio 2015 and 2017How to repro
ClonedialogTeam Explorerand clone progress bar to appearTeam ExplorerHow to test the fix
ClonedialogTeam Explorerand clone progress bar to appearTeam Explorer(with list of solutions to open)Fixes #2003