Fix PR icon in Status Bar and GitHub Icon on Start Page#1871
Fix PR icon in Status Bar and GitHub Icon on Start Page#1871grokys merged 3 commits intointernationalizationfrom
Conversation
Allows the `GitHub.InlineReviews` and `GitHub.StartPage` packages to be loaded, but now XAML resources cant be found.
This property is needed where an assembly has satellite assemblies that need to be installed.
|
There are more changes in #1714 that seem unnecessary or not really clear:
|
|
|
Sorry, I can understand English, but I can only rely on Google translation to express my ideas. |
#1714 broke a few things that were causing this:
IncludeOutputGroupsInVSIX/IncludeOutputGroupsInVSIXLocalOnlyproperties fromGitHub.VisualStudio.csproj. In the case ofGitHub.InlineReviewsandGitHub.StartPagethis prevented the packages loading which caused PR icon disappeared on the status bar #1863SatelliteDllsProjectOutputGroupto the relevant references in order to get the satellite assemblies to be shipped along with the extensionThis wasn't a bug, but was unnecessary:
OcticonPaths.resxdoesn't need to be translated as it consists solely of XAML paths.Fixes #1863