You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
immutable is easier to reason about, but most of our other models are mutable
note that most of our other models are mutable only because the syntax for initializing mutable instances is a lot more readable than for immutable instances
This group of classes and interfaces have a number of issues that make them difficult reason about and test.
Some issues
RepositoryModel,LocalRepositoryModelandRemoteRepositoryModelaren't models at allIGitServiceLocalRepositoryModelcontains mutating methods likeRefreshLocalRepositoryModelcontains utility methods likeGenerateUrlPlan of attack
LocalRepositoryModelintoIGitServiceRepositoryModelandLocalRepositoryModelinto pure modelsGenerateUrlis only used byLinkCommandso move that there as a private methodQuestions
Should the models be mutable or immutable?
@grokys said:
@jcansdale said: