This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Description Issue
If you clone a repo using incorrect casing in the owner. Some functionalities just don't work.
Visual Studio is https://github.com/github/VisualStudio.git
If you instead clone it with https://github.com/GitHub/VisualStudio.git
The following functionalities are broken
Any checked out branch will not be correlated to the corresponding pull request.
return pullRequest . HeadRepositoryOwner == repository . CloneUrl . Owner ;
Checking out an internal pull request will result in the branch path resembling that of a fork pull request checkout
else if ( repository . CloneUrl . Owner == pullRequest . HeadRepositoryOwner )
Multiple pull request sessions can exist
var key = Tuple . Create ( owner , number ) ;
The OpenFileInWorkingDirectory functionality does not work.
Other suspicious code paths
if ( context . SectionConnection . Username == item . CloneUrl . Owner )
Original Issue
I noticed this while working with another project...
public bool IsPullRequestFromRepository ( ILocalRepositoryModel repository , PullRequestDetailModel pullRequest )
{
return pullRequest . HeadRepositoryOwner == repository . CloneUrl . Owner ;
}
pullRequest.HeadRepositoryOwner is "justaprogrammer"
repository.CloneUrl.Owner is "JustAProgrammer"
Reactions are currently unavailable
Issue
If you clone a repo using incorrect casing in the owner. Some functionalities just don't work.
https://github.com/github/VisualStudio.githttps://github.com/GitHub/VisualStudio.gitThe following functionalities are broken
VisualStudio/src/GitHub.App/Services/PullRequestService.cs
Line 527 in 4af9d1c
VisualStudio/src/GitHub.App/Services/PullRequestService.cs
Line 395 in 4af9d1c
VisualStudio/src/GitHub.InlineReviews/Services/PullRequestSessionManager.cs
Line 228 in 4af9d1c
OpenFileInWorkingDirectoryfunctionality does not work.Other suspicious code paths
VisualStudio/src/GitHub.VisualStudio.UI/UI/Views/GitHubConnectContent.xaml.cs
Line 78 in 4af9d1c
Original Issue
I noticed this while working with another project...
VisualStudio/src/GitHub.App/Services/PullRequestService.cs
Lines 525 to 528 in 4af9d1c
pullRequest.HeadRepositoryOwneris "justaprogrammer"repository.CloneUrl.Owneris "JustAProgrammer"