Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Incorrect casing in the clone url owner causes issues #1804

@StanleyGoldman

Description

@StanleyGoldman

Issue

If you clone a repo using incorrect casing in the owner. Some functionalities just don't work.

  • Visual Studio is https://github.com/github/VisualStudio.git
  • If you instead clone it with https://github.com/GitHub/VisualStudio.git
The following functionalities are broken
Other suspicious code paths

Original Issue

I noticed this while working with another project...

public bool IsPullRequestFromRepository(ILocalRepositoryModel repository, PullRequestDetailModel pullRequest)
{
return pullRequest.HeadRepositoryOwner == repository.CloneUrl.Owner;
}

pullRequest.HeadRepositoryOwner is "justaprogrammer"
repository.CloneUrl.Owner is "JustAProgrammer"

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions