Merged
Conversation
Allows updates to modbus-pdu and mocha, serialport limited to <7 for continued node 4 & 5 support
- extended NodeJS version - excluded dtslint for Node 4 & 5
- removed NodeJS version > 8 as modbus-pdu tests fail - moved dtslint condition to stage
- removed stages - moved condition to job
- updated build matrix to not run DTS lint for node v4/v5
- fixed env check
TypeScript definitions
Disable debug
It looks the call signature for `readCoils` in the first example uses the ([old](https://github.com/dresende/node-modbus-tcp#client-methods)) `{ from: ..., to: ... }` syntax instead of `{ address: ..., quantity: ... }`. I couldn't find the `test.js` file mentioned, but the tests that I did see used the latter syntax (except for the predecessor project [`node-modbus-tcp`](https://github.com/dresende/node-modbus-tcp/blob/master/test/integration/read-coils.js#L27)): * [`pdu` test for "read coils" operation](https://github.com/node-modbus/pdu/blob/master/test/integration/read-coils.js#L4) * [`quirks.js`](https://github.com/node-modbus/stream/blob/master/test/integration/quirks.js#L24)
doc: correct syntax contradiction in README.md example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.