Merged
Conversation
For ArcRotateCamera, getAbsolutePosition() returns the camera's world position (orbit centre + orbital offset), not the orbit centre itself. Using that Y value as the new setTarget() height displaced the orbit centre upward by the full orbital offset, making the camera tilt down instead of staying level. Fix: use mesh1.target?.y (the actual orbit-centre Y for ArcRotateCamera, and the current look-at Y for FreeCamera) so that only the X/Z of the orbit centre changes, giving a pure horizontal yaw with no pitch change. https://claude.ai/code/session_012ASzHmpUWv39A2j5hiFzyc
…xis-jlM0I Fix camera target Y position fallback in flock transform
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.