Add Profiler mode to fixtures even if React DevTools is not installed#31877
Merged
sebmarkbage merged 1 commit intofacebook:mainfrom Dec 28, 2024
Merged
Add Profiler mode to fixtures even if React DevTools is not installed#31877sebmarkbage merged 1 commit intofacebook:mainfrom
sebmarkbage merged 1 commit intofacebook:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: ab27231dc51aa2535df37555797e630d31047fa4...1891d2ed400ec1cb534988da1ca41ffd52723c8c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
d4e49b6 to
fb16203
Compare
hoxyq
approved these changes
Dec 21, 2024
This was referenced Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently you need to do one of either:
To opt in to component level profiling.
It was a bit confusing that some of the fixtures was doing 2 which made them work while other was depending on if you had DevTools.
Really React Refresh shouldn't really opt you in I think.