Skip to content

Support @latest in prepare-release-from-ci #21616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acdlite merged 1 commit into from
Jun 3, 2021
Merged

Support @latest in prepare-release-from-ci #21616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/release/prepare-release-from-ci.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ const run = async () => {
await testPackagingFixture(params);
}

await printPrereleaseSummary(params, false);
const isLatestRelease = params.releaseChannel === 'latest';
await printPrereleaseSummary(params, isLatestRelease);
Copy link
Copy Markdown
Contributor

@bvaughn bvaughn Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we pin differently for the latest release?

Copy link
Copy Markdown
Collaborator Author

@acdlite acdlite Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's "pin" mean in this context?

Copy link
Copy Markdown
Contributor

@bvaughn bvaughn Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh, nevermind sorry. I misread this.

} catch (error) {
handleError(error);
}
Expand Down
3 changes: 3 additions & 0 deletions scripts/release/shared-commands/download-build-artifacts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,13 @@ const run = async ({build, cwd, releaseChannel}) => {
await exec(`rm -rf ./build/node_modules`, {cwd});
}
let sourceDir;
// TODO: Rename release channel to `next`
if (releaseChannel === 'stable') {
sourceDir = 'oss-stable';
} else if (releaseChannel === 'experimental') {
sourceDir = 'oss-experimental';
} else if (releaseChannel === 'latest') {
sourceDir = 'oss-stable-semver';
} else {
console.error('Internal error: Invalid release channel: ' + releaseChannel);
process.exit(releaseChannel);
Expand Down
10 changes: 7 additions & 3 deletions scripts/release/shared-commands/parse-params.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,21 @@ const paramDefinitions = [
name: 'releaseChannel',
alias: 'r',
type: String,
description: 'Release channel (stable or experimental)',
description: 'Release channel (stable, experimental, or latest)',
},
];

module.exports = async () => {
const params = commandLineArgs(paramDefinitions);

const channel = params.releaseChannel;
if (channel !== 'experimental' && channel !== 'stable') {
if (
channel !== 'experimental' &&
channel !== 'stable' &&
channel !== 'latest'
) {
console.error(
theme.error`Invalid release channel (-r) "${channel}". Must be "stable" or "experimental".`
theme.error`Invalid release channel (-r) "${channel}". Must be "stable", "experimental", or "latest".`
);
process.exit(1);
}
Expand Down