[Android] possible regression with `:app:mergeReleaseResources` in 0.60.0-rc.1

[robertying]

Problems

Those problems were introduced in 0.60.0-rc:

1. import packageJson from './package.json' causes error

   Execution failed for task ':app:mergeReleaseResources'.
   > /Users/rying/repos/resourcesRepro/android/app/src/main/res/raw/package.json: Error: package is not a valid resource name (reserved Java keyword)
   

   Apparently package.json got copied to res/raw which makes gradle complain. This works fine in 0.59.x, however.

2. All those generated resources (e.g. package.json, app.json...) get moved to android/app/src/main/res.

   • I believe those generated resources should not be moved into this directory since they are generated on the fly. The current behavior in 0.60.0-rc makes it difficult for Git version control - they should always in build rather than src.
   • Because of this, metro will also complain:

      jest-haste-map: Haste module naming collision: myapp
        The following files share their name; please adjust your hasteImpl:
          * <rootDir>/package.json
          * <rootDir>/android/app/src/main/res/raw/package.json
     

     I need to add those files into metro's blacklist to stop this error. ;(

Possible relevant commits

• 962437f

• eb534bc

React Native version:

  System:
    OS: macOS 10.14.5
    CPU: (4) x64 Intel(R) Core(TM) i3-8100B CPU @ 3.60GHz
    Memory: 194.87 MB / 8.00 GB
    Shell: 5.7.1 - /usr/local/bin/zsh
  Binaries:
    Node: 12.4.0 - /usr/local/Cellar/node/12.4.0/bin/node
    Yarn: 1.16.0 - /usr/local/Cellar/node/12.4.0/bin/yarn
    npm: 6.9.0 - /usr/local/Cellar/node/12.4.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
  IDEs:
    Android Studio: 3.4 AI-183.6156.11.34.5522156
    Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6 
    react-native: 0.60.0-rc.1 => 0.60.0-rc.1

Steps To Reproduce

1. Clone https://github.com/robertying/resources-repro
2. yarn
3. react-native run-android --variant release

[react-native-bot]

Can you run react-native info and edit your issue to include these results under the React Native version: section?

Details

If you believe this information is irrelevant to the reported issue, you may write `[skip envinfo]` alongside an explanation in your Environment: section.

[robertying]

@react-native-bot it is included already :(

[rozPierog]

Update Gradle to newest version. Should resolve this issue

[robertying]

Hi @rozPierog I'm already using the latest gradle 5.4.1 and gradle plugin 3.4.1 generated from RN 0.60 template.

[mikehardy]

@robertying unfortunately this is coming from a PR I proposed. The underlying problem it was trying to solve is here #22234 and the PR I proposed was a version of a patch developed on that issue that seemed to work for everyone for nearly a year. Is there a better way to solve the original problem?

[robertying]

Hi @mikehardy thanks for reaching out here :) I believe these commits have only recently been picked into release. So most of people have not had it yet, I assume?

Regarding your question, I remember one guy from that thread said some other guys put extra resources in version control so that he had the issue. In that case, I believe they could just remove those generated resources from version control and it should work. What’s your opinion?

[robertying]

So now I have tested the following:

• Clean repo generated from react-native init resoucesRepro59 (so it uses 0.59.9):

  1. Add import packageJson from './package.json' to App.js.
  2. No package.json bundled into android/app/build
  3. All content in package.json is copied to index.android.bundle

• Clean repo generated from react-native init resoucesRepro --version react-native@next (so it uses 0.60.0-rc):

  1. Add import packageJson from './package.json' to App.js.
  2. app.json, package.json and other generated stuff like node_module_*** get copied to android/app/src/res.
  3. Content in package.json should still be copied to index.android.bundle but I cannot know since the build fails early.

These scripts somehow copy unnecessary files to resources dir starting in 0.60.0.

So I think there are actually two issues I want to address:

• Imported files in JS files such as package.json being copied to android/app/build/generated/res directory. (not happen in 0.59.9; not related to @mikehardy's commits)
• Generated res directory being copied to android/app/src/res which I believe is not a good practice. (not happen in 0.59.9 either; related to @mikehardy's commits)