Skip to content

Add exclusion paths for coreclr CI builds#49

Merged
safern merged 2 commits intodotnet:masterfrom
safern:CoreclrCiExclusions
Nov 15, 2019
Merged

Add exclusion paths for coreclr CI builds#49
safern merged 2 commits intodotnet:masterfrom
safern:CoreclrCiExclusions

Conversation

@safern
Copy link
Copy Markdown
Member

@safern safern commented Nov 14, 2019

Copy link
Copy Markdown
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one non-blocking question but LGTM overall, thanks for fixing this!

Copy link
Copy Markdown
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need these changes in pr.yml as well.

@safern
Copy link
Copy Markdown
Member Author

safern commented Nov 14, 2019

Updated to address feedback. Would appreciate another review.

Copy link
Copy Markdown
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jarret is the expert on include / exclude precedence but to me this still looks good.

Copy link
Copy Markdown
Contributor

@jashook jashook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably should delete perf.yml.

@trylek
Copy link
Copy Markdown
Member

trylek commented Nov 14, 2019

@jashook - doesn't [didn't] "dotnet-coreclr perf" still use it?

@jashook
Copy link
Copy Markdown
Contributor

jashook commented Nov 14, 2019

Ya I think the pipeline will die with consolidation.

@trylek
Copy link
Copy Markdown
Member

trylek commented Nov 14, 2019

Looks like we might want to invite @DrewScoggins to this party...

@jashook
Copy link
Copy Markdown
Contributor

jashook commented Nov 14, 2019

Looks like the CI is still painfully slow to acquire machines.

@safern
Copy link
Copy Markdown
Member Author

safern commented Nov 15, 2019

I will go ahead and merge this as builds were triggered just fine.

@safern safern merged commit 9f41cbb into dotnet:master Nov 15, 2019
@safern safern deleted the CoreclrCiExclusions branch November 15, 2019 00:03
@DrewScoggins
Copy link
Copy Markdown
Member

Thanks for the tag @trylek

Our current performance jobs only run on the internal side of AzDO, and as of now I do not see any of the new jobs there. Will we need to do additional work to bring that side of the house back online?

@trylek
Copy link
Copy Markdown
Member

trylek commented Nov 15, 2019

@DrewScoggins - For the various side CoreCLR pipelines like gcstress, jitstress, r2r et al. I have already created their counterparts for the runtime repo. For dotnet-coreclr perf I don't have the credentials to create an internal pipeline. I can either create that as a public pipeline (if that's desirable) or you or someone with the access rights needs to do it or grant me rights to do that :-).

@jashook
Copy link
Copy Markdown
Contributor

jashook commented Nov 15, 2019

@DrewScoggins @trylek @BruceForstall I believe porting the existing pipeline as is, is most likely the incorrect way to move forward. We should meet to discuss what things look like going forward before making this port.

@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants