Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Fix closed_over_null computation in mono_marshal_get_delegate_invoke_internal by comparing invoke sig param count with actual target method param count directly, rather than via the stripped signature which underflows when the invoke sig has 0 params. Fix MINT_CALL_DELEGATE in the interpreter to handle closed-over-null case where an instance method is bound with null this, instead of incorrectly falling through to the static-call memmove path. Add regression tests for CreateDelegate closed over null. Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/b2d407d8-e6b9-4fba-974a-ec751a17db84 Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
|
@copilot investigate the failures in the new tests |
The new delegate tests (
The only CI failures are in The 3 cancelled jobs (CoreCLR windows x64/x86 Debug/Release, browser-wasm windows LibraryTests) were dependency-cancelled due to the unrelated wasm failures. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/49c5407b-85f7-464b-ba8e-255cf0fcab34 Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/dd0dd922-0dee-48e2-a8cb-ee3299c87022 Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
closed_over_nullwrapper embeds direct CALL to target method, can't be pre-compiled by AOTemit_delegate_invoke_internal_ilgenin marshal-lightweight.c to use indirect call throughmethod_ptrforclosed_over_nullinstead of direct CALL, so the wrapper can be AOT-compiledWRAPPER_SUBTYPE_DELEGATE_INVOKE_CLOSED_OVER_NULLsubtype for separate caching and AOT encoding/decodingclosed_over_nullparameter tomono_marshal_get_delegate_invoke_internaland update all callersaot-compiler.c) to also pre-compileclosed_over_nullvariant for all delegate typesclosed_over_nullvs regularcallvirtwrappers in marshal.cConditionalFactskip in DelegateTests.cs — tests should pass after the fix📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.