Fix #14471: Improve check: shadowVariable for function argument#8303
Open
ludviggunne wants to merge 8 commits intodanmar:mainfrom
Open
Fix #14471: Improve check: shadowVariable for function argument#8303ludviggunne wants to merge 8 commits intodanmar:mainfrom
ludviggunne wants to merge 8 commits intodanmar:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ludviggunne
force-pushed
the
14471
branch
3 times, most recently
from
8d1541b to
a5e4899
Compare
Collaborator
|
This should allow us to enable |
ludviggunne
force-pushed
the
14471
branch
2 times, most recently
from
55fc5b2 to
a005907
Compare
Collaborator
|
Since this now reports shadowed functions the error ID is misleading. We probably need a new ID. |
Collaborator
Author
The error ID does differ actually, e.g. |
Collaborator
Ah, sorry. I just went by the title of the PR and did not look at the code. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.