CM-61986-add-mcp-and-email-enrichment-from-claude-json#421
Open
RoniCycode wants to merge 2 commits intomainfrom
Open
CM-61986-add-mcp-and-email-enrichment-from-claude-json#421RoniCycode wants to merge 2 commits intomainfrom
RoniCycode wants to merge 2 commits intomainfrom
Conversation
RoniCycode
requested review from
elsapet,
gotbadger and
mateusz-sterczewski
as code owners
elsapet
approved these changes
Apr 1, 2026
Collaborator
elsapet
left a comment
elsapet
left a comment
There was a problem hiding this comment.
Overall looks good -- no blockers
One consideration would be that the .claude.json has no public-facing documentation that I can find, and so its structure is not necessarily stable (i.e. we cannot rely on oauthAccount.emailAddress always being present, for example). I see that we set email to None in this case, so I assume this instability is understood
Also, the branch name mentions MCP but I don't see any functionality around this -- @RoniCycode does it come in a separate PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.