Fix Windows NTP server concatenation#185
Conversation
|
Hello, thank you for the proposed fix. Adding here the reason for this change - according to the |
|
We will be soon switching to Github PRs (currently still using opendev) and one of the requirements will be the DCO with signed commits. Can you please add the link to the documentation in your commit and sign the commit? Thanks. |
|
Also, if you can please rebase the PR so that I can trigger the workflows runs. Thank you. |
5d80413 to
aa5f3f6
Compare
From Microsoft's documentation for w32time: https://learn.microsoft.com/en-us/windows-server/networking/windows-time-service/windows-time-service-tools-and-settings?tabs=config#command-line-parameters-for-w32time /manualpeerlist:<peers>: Sets the manual peer list to <peers>, which is a space-delimited list of Domain Name System (DNS) or IP addresses. When you specify multiple peers, this option must be enclosed in quotation marks.
aa5f3f6 to
a6e1ce9
Compare
|
Hello, can you please rebase for the tests to pass and also sign off the commit as per DCO https://github.com/cloudbase/cloudbase-init/blob/master/DCO? Thanks. |
|
Hello, you can do something like |
Ensure the list of NTP servers is space delimited