This repository was archived by the owner on Oct 29, 2025. It is now read-only.
Merged
Conversation
krumware
suggested changes
Feb 7, 2024
Contributor
krumware
left a comment
krumware
left a comment
There was a problem hiding this comment.
Does this variable need to be added to the table in the readme?
Outside of that, looks good to me, and looks like it will be backwards compatible so that users don't have to update their .env files out of the gate.
krumware
approved these changes
Feb 8, 2024
Contributor
krumware
left a comment
krumware
left a comment
There was a problem hiding this comment.
Thanks for the readme update @keithwillcode. LGTM
keithwillcode
deleted the
zomars/dops-27-docker-builds-are-broken-because-of-direct_database_url
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing DIRECT_DATABASE_URL env variables that we're breaking docker builds.