add more checks for keylen

[fanatid]

Part of #22

[fanatid]

$ node -v
v5.6.0
$ node
> require('crypto').pbkdf2Sync('password', 'salt', 1, NaN)
TypeError: Bad key length
$ nvm use 0.10
$ node -v
v0.10.42
$ node
> require('crypto').pbkdf2Sync('password', 'salt', 1, NaN)
<SlowBuffer >

Different behavior for different node versions :(

[dcousens]

I'd rather add these fixtures inline here, then do this weird modification which is error prone for others adding tests.

[fanatid]

Agree, any ideas how tests dkLen with NaN and Infinity?

[dcousens]

What do you mean?

[fanatid]

oops, sorry

[fanatid]

updated

[dcousens]

... all failed except Node 4? Interesting

[dcousens]

 1) node pbkdf2 pbkdf2-compat pbkdf2Sync sha[1/224/256/384/512] should throw Bad key length:
     AssertionError: Missing expected exception..
      at Function._throws (assert.js:301:5)
      at Function.assert.throws (assert.js:318:11)
      at Context.<anonymous> (test/index.js:95:24)

[fanatid]

What version of node v4 you are using? May be your version not include nodejs/node@4c8d96b ? (checks on NaN and Infinity was added there)

[dcousens]

@fanatid I'm referring to the CI.
Every version except Node 4 are failing this.

[fanatid]

@dcousens I'll fix with this PR after nodejs/node#5397 will be merged and released

[calvinmetcalf]

merged as part of #27