Add workaround for bpo-36880 crash to ctypes_patch#136
Merged
freakboy3742 merged 4 commits intobeeware:masterfrom May 25, 2019
Merged
Add workaround for bpo-36880 crash to ctypes_patch#136freakboy3742 merged 4 commits intobeeware:masterfrom
freakboy3742 merged 4 commits intobeeware:masterfrom
Conversation
Previously, our ctypes_patch would trigger a bug in ctypes (see https://bugs.python.org/issue36880 and python/cpython#13364), which would eventually crash Python if done too often. This workaround changes our ctypes_patch implementation so that it no longer triggers the ctypes bug. This fixes the crash reported in beeware/toga#549.
freakboy3742
approved these changes
May 25, 2019
Member
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
This is deliciously ugly... Nicely done :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the crash reported in beeware/toga#549 by adding a workaround for CPython/
ctypesbug bpo-36880.I've also made a PR to CPython with a fix for the bug itself (python/cpython#13364). This workaround is still important though, as it prevents the crash on Python versions that don't have the proper fix (which is currently all of them, and even once the patch gets merged it will only be included with Python 3.8 and newer, and maybe in a future Python 3.7 update).