Make root level tracing span (TracingLayer) optional#911
Closed
Make root level tracing span (TracingLayer) optional#911
Conversation
calavera
suggested changes
Jul 15, 2024
Contributor
Author
|
@calavera , thank you. It is very embarrassing how I missed it. The solution was hiding in the plain sight. Sorry for wasting so much of your time on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📬 A demo implementation for the log clutter issue discussed in #672.
It needs more work (docs, tests, better env var parsing)
✍️ Description of changes:
Reuse
AWS_LAMBDA_LOG_FORMATto specify if the root span should not be created.E.g.
AWS_LAMBDA_LOG_FORMAT=no-spanorAWS_LAMBDA_LOG_FORMAT=json,no-spanThe
TracingLayeris added by default and not added ifAWS_LAMBDA_LOG_FORMATcontainsno-span.Impact
This last point allows using different log formats in different environments without code changes.
Examples
Including the root span
No root span (the main goal of this PR)
Root span + JSON
{"level":"INFO","fields":{"message":"With global default provider"},"span":{"requestId":"local-request-id","xrayTraceId":"Root=0-00000000-000000000000000000000000;Parent=0000000000000000;Sampled=0;Lineage=00000000:0","name":"Lambda runtime invoke"},"spans":[{"requestId":"local-request-id","xrayTraceId":"Root=0-00000000-000000000000000000000000;Parent=0000000000000000;Sampled=0;Lineage=00000000:0","name":"Lambda runtime invoke"}]} {"level":"INFO","fields":{"message":"Command received: echo"},"span":{"requestId":"local-request-id","xrayTraceId":"Root=0-00000000-000000000000000000000000;Parent=0000000000000000;Sampled=0;Lineage=00000000:0","name":"Lambda runtime invoke"},"spans":[{"requestId":"local-request-id","xrayTraceId":"Root=0-00000000-000000000000000000000000;Parent=0000000000000000;Sampled=0;Lineage=00000000:0","name":"Lambda runtime invoke"}]} {"level":"ERROR","fields":{"message":"\"Error\""},"span":{"requestId":"local-request-id","xrayTraceId":"Root=0-00000000-000000000000000000000000;Parent=0000000000000000;Sampled=0;Lineage=00000000:0","name":"Lambda runtime invoke"},"spans":[{"requestId":"local-request-id","xrayTraceId":"Root=0-00000000-000000000000000000000000;Parent=0000000000000000;Sampled=0;Lineage=00000000:0","name":"Lambda runtime invoke"}]}No root span + JSON
{"level":"INFO","fields":{"message":"With global default provider"}} {"level":"INFO","fields":{"message":"Command received: echo"}} {"level":"ERROR","fields":{"message":"\"Error\""}}🔏 By submitting this pull request
cargo +nightly fmt.cargo clippy --fix.