Fix Java client time column access throwing ArrayIndexOutOfBoundsException (#17407)#17408
Open
PDGGK wants to merge 1 commit intoapache:masterfrom
Open
Fix Java client time column access throwing ArrayIndexOutOfBoundsException (#17407)#17408PDGGK wants to merge 1 commit intoapache:masterfrom
PDGGK wants to merge 1 commit intoapache:masterfrom
Conversation
…ption (apache#17407) Add tsBlockColumnIndex < 0 guards to all ByTsBlockColumnIndex getter methods that were missing them. When the time pseudo-column is accessed through a typed getter other than getLong or getString, throw StatementExecutionException instead of causing ArrayIndexOutOfBoundsException from TsBlock.getColumn(-1). Signed-off-by: Zihan Dai <1436286758@qq.com>
PDGGK
force-pushed
the
fix/java-client-time-column-guard
branch
from
4cbf842 to
5d080cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17407
This is the Java equivalent of the C++ client fix in #17400.
In
IoTDBRpcDataSet.java, severalByTsBlockColumnIndexgetter methods do not handletsBlockColumnIndex < 0(the time pseudo-column in tree model). OnlygetLongByTsBlockColumnIndexandgetStringByTsBlockColumnIndexcorrectly handle this case. The remaining typed getters pass the negative index directly toTsBlock.getColumn(), causingArrayIndexOutOfBoundsException.Changes
Add
tsBlockColumnIndex < 0guards that throwStatementExecutionExceptionwith a clear message:getBooleanByTsBlockColumnIndex"Cannot read boolean from time column"getDoubleByTsBlockColumnIndex"Cannot read double from time column"getFloatByTsBlockColumnIndex"Cannot read float from time column"getIntByTsBlockColumnIndex"Cannot read int32 from time column"getBinaryTsBlockColumnIndex"Cannot read binary from time column"getObjectByTsBlockIndex"Cannot read object from time column"This is consistent with
getLongByTsBlockColumnIndexwhich returns the time value for< 0, andgetStringByTsBlockColumnIndexwhich returns the time value as a string. For non-compatible types, throwing a descriptive exception is preferred over an opaqueArrayIndexOutOfBoundsException.