Skip to content

chore(ci): pin actions in non-PR-triggered workflows#3193

Merged
kevinjqliu merged 1 commit intomainfrom
chore/zizmor-non-pr-triggered-workflows
Mar 28, 2026
Merged

chore(ci): pin actions in non-PR-triggered workflows#3193
kevinjqliu merged 1 commit intomainfrom
chore/zizmor-non-pr-triggered-workflows

Conversation

@kevinjqliu
Copy link
Copy Markdown
Contributor

@kevinjqliu kevinjqliu commented Mar 27, 2026

What changed

  • Pinned external GitHub Actions to full commit SHAs in non-PR-triggered workflows:
    • .github/workflows/nightly-pypi-build.yml
    • .github/workflows/pypi-build-artifacts.yml
    • .github/workflows/python-release-docs.yml
    • .github/workflows/python-release.yml
    • .github/workflows/stale.yml
    • .github/workflows/svn-build-artifacts.yml
  • Updated one command in pypi-build-artifacts.yml from expression interpolation to shell env usage:
    • uv version "${{ env.VERSION }}" -> uv version "$VERSION"

Why

  • Fixes zizmor findings for unpinned-uses by replacing mutable refs with immutable SHAs.
  • Reduces supply-chain risk from tag/branch drift while preserving workflow behavior.
  • Fixes template-injection warning by avoiding direct expression expansion inside run.

Verification

  • uvx --from zizmor zizmor --offline .github/workflows/ --fix=all
  • Result: No findings to report.

@kevinjqliu kevinjqliu merged commit 1e7f306 into main Mar 28, 2026
4 checks passed
@kevinjqliu kevinjqliu deleted the chore/zizmor-non-pr-triggered-workflows branch March 28, 2026 17:04
kevinjqliu added a commit that referenced this pull request Mar 31, 2026
<!--
Thanks for opening a pull request!
-->

<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->

# Rationale for this change
Follow up to #3193
env vars does not play nice with windows os (because the default shell
is powershell). We need to set to bash so that env vars are interpreted
correctly

## Are these changes tested?
Yes
Ran on fork
nightly:
https://github.com/kevinjqliu/iceberg-python/actions/runs/23805622644
release:
https://github.com/kevinjqliu/iceberg-python/actions/runs/23805619712

## Are there any user-facing changes?

<!-- In the case of user-facing changes, please add the changelog label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants