Skip to content

Apply suggestions from code review

c5f3efd
Select commit
Loading
Failed to load commit list.
Merged

GUI whitelabel runtime system #8942

Apply suggestions from code review
c5f3efd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 14, 2025 in 1s

16.56% (-0.02%) compared to 8e4fe1c

View this Pull Request on Codecov

16.56% (-0.02%) compared to 8e4fe1c

Details

Codecov Report

Attention: Patch coverage is 8.84265% with 701 lines in your changes missing coverage. Please review.

Project coverage is 16.56%. Comparing base (8e4fe1c) to head (c5f3efd).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...ache/cloudstack/gui/theme/GuiThemeServiceImpl.java 24.32% 166 Missing and 2 partials ⚠️
...va/org/apache/cloudstack/gui/theme/GuiThemeVO.java 0.00% 80 Missing ⚠️
...ache/cloudstack/api/response/GuiThemeResponse.java 0.00% 75 Missing ⚠️
...oudstack/gui/theme/dao/GuiThemeDetailsDaoImpl.java 0.00% 66 Missing ⚠️
.../cloudstack/gui/theme/dao/GuiThemeJoinDaoImpl.java 1.53% 64 Missing ⚠️
.../api/command/user/gui/theme/UpdateGuiThemeCmd.java 0.00% 46 Missing ⚠️
.../api/command/user/gui/theme/CreateGuiThemeCmd.java 0.00% 43 Missing ⚠️
...rg/apache/cloudstack/gui/theme/GuiThemeJoinVO.java 0.00% 43 Missing ⚠️
...k/api/command/user/gui/theme/ListGuiThemesCmd.java 0.00% 36 Missing ⚠️
...apache/cloudstack/gui/theme/GuiThemeDetailsVO.java 0.00% 32 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8942      +/-   ##
============================================
- Coverage     16.57%   16.56%   -0.02%     
- Complexity    13988    14009      +21     
============================================
  Files          5745     5758      +13     
  Lines        510847   511578     +731     
  Branches      62140    62192      +52     
============================================
+ Hits          84696    84755      +59     
- Misses       416677   417350     +673     
+ Partials       9474     9473       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.