You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Because restart assumes it's being called against the global browser instance, the global browser instance will be overwritten with the restarted b2 instance, and b2 will still be pointing to original (now closed) forked instance.
I propose we have restart return the new instance. We can still overwrite the global instance when appropriate too (just add an if statement here). So now the code will be:
Let's say you do the following:
Because
restartassumes it's being called against the global browser instance, the globalbrowserinstance will be overwritten with the restartedb2instance, andb2will still be pointing to original (now closed) forked instance.I propose we have
restartreturn the new instance. We can still overwrite the global instance when appropriate too (just add anifstatement here). So now the code will be:Whatever we end up doing to
forkNewDriverInstancein #3892 we'll have to also do torestartforasync/awaitusers.