♻️ Remove dependency on 'fs-extra' by utilizing nodejs builtin fs.promises#26263
Closed
samouri wants to merge 1 commit intoampproject:masterfrom
Closed
♻️ Remove dependency on 'fs-extra' by utilizing nodejs builtin fs.promises#26263samouri wants to merge 1 commit intoampproject:masterfrom
samouri wants to merge 1 commit intoampproject:masterfrom
Conversation
|
Hey @erwinmombay, these files were changed:
Hey @jridgewell, these files were changed:
|
Member
Author
|
Argh, this idea didn't work. We utilize some of the extra |
Contributor
Yep, I tried removing as many of the unnecessary uses of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nodejs builtin fs.promises is no longer experimental. Therefore I think its fair to remove our dependency on
fs-extra.